feat: fix contracts-sdk #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshLong145
approved these changes
Feb 15, 2024
Comment on lines
+55
to
+61
| let CID: any; | ||
| try { | ||
| CID = require('multiformats/cid'); | ||
| } catch (e) { | ||
| console.log('CID not found'); | ||
| } | ||
|
|
There was a problem hiding this comment.
For context this is the original implementation which does correctly transpile. We are essentially doing a revert with pr to an earlier implementation which could transpile to all of our required targets.
Ansonhkg
added a commit
that referenced
this pull request
Feb 21, 2024
* init release * feat: fix contracts-sdk (#359) * use testThis in testThese to unify criteria and fix the pipeline that… (#360) * use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0 * fmt * remove problematic process.exit * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type * add CI run on PRs targeting staging branches (#361) * add comment pointing to repo (#362) * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * add comment pointing to repo --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> * prettied * feature/lit-2511-js-sdk-review-remove-lit-siwe (#373) * implement new interface to unify session authentication in client (#358) * implement new interface to unify session authentication in client * fix eth pkp wallet creation unit test * update test to use global config * add test group to CI * change encryption test to also validate getting session sigs from cache * remove process termination order included on testThese that was avoiding other tests to run * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * fix rpc constant used in testing * add empty resourceAbilityRequests to test * fix and clean test using new session cache interface to sign using PKPEthersWallet * fix encryption test * remove old test * staging * chore: update readme * v? * use throwError function * remove unnnecessary sessionKeys as they are obtained from cache afterwards * move authContext validation to function that validates the PKP auth context * backwards compatibility to avoid a breaking change * fmt * fmt * fix siwe import --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> Co-authored-by: Ansonhkg <ansonox@gmail.com> * remove vanilla js builds (#372) * Feature/lit 2494 js sdk get rid of lit third party libs (#371) * remove 3rd party libs * fix: revert back to fix react * it works * cherry picks 735438f 3b0422f * readme * resolve conflicts --------- Signed-off-by: Anson <ansonox@gmail.com> * fix: build issues * chore: bump accs-schema version to 0.0.6 * update accs schemas version (#375) * update accs schemas version * 0.0.6 instead cus we pub the dist folder --------- Co-authored-by: Ansonhkg <ansonox@gmail.com> * fix: wrong error message * Feature/lit 2491 js sdk make delegateeAddresses field optional (#376) * chore: bump accs-schema version to 0.0.6 * fix: wrong error message * feat: make delegatee Optional * feat: add test * fix: test case & add extra info on logs * update: test case comment * feature/lit-2544-js-sdk-remove-vanilla-js-from-readme * Published version 3.2.0 --------- Signed-off-by: Anson <ansonox@gmail.com> Co-authored-by: Federico Amura <federicoamura@gmail.com> Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> Co-authored-by: Chris Cassano <1285652+glitch003@users.noreply.github.com>
Ansonhkg
added a commit
that referenced
this pull request
Feb 22, 2024
* init release * feat: fix contracts-sdk (#359) * use testThis in testThese to unify criteria and fix the pipeline that… (#360) * use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0 * fmt * remove problematic process.exit * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type * add CI run on PRs targeting staging branches (#361) * add comment pointing to repo (#362) * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * add comment pointing to repo --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> * prettied * feature/lit-2511-js-sdk-review-remove-lit-siwe (#373) * implement new interface to unify session authentication in client (#358) * implement new interface to unify session authentication in client * fix eth pkp wallet creation unit test * update test to use global config * add test group to CI * change encryption test to also validate getting session sigs from cache * remove process termination order included on testThese that was avoiding other tests to run * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * fix rpc constant used in testing * add empty resourceAbilityRequests to test * fix and clean test using new session cache interface to sign using PKPEthersWallet * fix encryption test * remove old test * staging * chore: update readme * v? * use throwError function * remove unnnecessary sessionKeys as they are obtained from cache afterwards * move authContext validation to function that validates the PKP auth context * backwards compatibility to avoid a breaking change * fmt * fmt * fix siwe import --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> Co-authored-by: Ansonhkg <ansonox@gmail.com> * remove vanilla js builds (#372) * Feature/lit 2494 js sdk get rid of lit third party libs (#371) * remove 3rd party libs * fix: revert back to fix react * it works * cherry picks 735438f 3b0422f * readme * resolve conflicts --------- Signed-off-by: Anson <ansonox@gmail.com> * fix: build issues * Check certificate before passing to wasm --------- Signed-off-by: Anson <ansonox@gmail.com> Co-authored-by: Ansonhkg <ansonox@gmail.com> Co-authored-by: Federico Amura <federicoamura@gmail.com> Co-authored-by: Massimo Cairo <cairomassimo@gmail.com>
Ansonhkg
added a commit
that referenced
this pull request
Feb 22, 2024
* init patch * Feature/lit 2545 js sdk fix cosmjscrypto (#381) * fix: should add dependencies to related packages * fix: include cosmos dependencies * fix: correct version * fix: correct version * Check certificate before passing to wasm (#374) * init release * feat: fix contracts-sdk (#359) * use testThis in testThese to unify criteria and fix the pipeline that… (#360) * use testThis in testThese to unify criteria and fix the pipeline that was missing some tests due to testThese finishing the process with code 0 * fmt * remove problematic process.exit * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type * add CI run on PRs targeting staging branches (#361) * add comment pointing to repo (#362) * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * add comment pointing to repo --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> * prettied * feature/lit-2511-js-sdk-review-remove-lit-siwe (#373) * implement new interface to unify session authentication in client (#358) * implement new interface to unify session authentication in client * fix eth pkp wallet creation unit test * update test to use global config * add test group to CI * change encryption test to also validate getting session sigs from cache * remove process termination order included on testThese that was avoiding other tests to run * Add `K256` as alias of `ECDSA_CAIT_SITH` sig type (#356) * fix rpc constant used in testing * add empty resourceAbilityRequests to test * fix and clean test using new session cache interface to sign using PKPEthersWallet * fix encryption test * remove old test * staging * chore: update readme * v? * use throwError function * remove unnnecessary sessionKeys as they are obtained from cache afterwards * move authContext validation to function that validates the PKP auth context * backwards compatibility to avoid a breaking change * fmt * fmt * fix siwe import --------- Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> Co-authored-by: Ansonhkg <ansonox@gmail.com> * remove vanilla js builds (#372) * Feature/lit 2494 js sdk get rid of lit third party libs (#371) * remove 3rd party libs * fix: revert back to fix react * it works * cherry picks 735438f 3b0422f * readme * resolve conflicts --------- Signed-off-by: Anson <ansonox@gmail.com> * fix: build issues * Check certificate before passing to wasm --------- Signed-off-by: Anson <ansonox@gmail.com> Co-authored-by: Ansonhkg <ansonox@gmail.com> Co-authored-by: Federico Amura <federicoamura@gmail.com> Co-authored-by: Massimo Cairo <cairomassimo@gmail.com> * fix: add blockhash to react demo app (#379) --------- Signed-off-by: Anson <ansonox@gmail.com> Co-authored-by: Chris Cassano <1285652+glitch003@users.noreply.github.com> Co-authored-by: Federico Amura <federicoamura@gmail.com> Co-authored-by: Massimo Cairo <cairomassimo@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Then run in react app
Run test
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: