-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/lit 1815 pull node urls from chain in sdk instead of using hardcoded #245
Closed
Ansonhkg
wants to merge
261
commits into
master
from
feature/lit-1815-pull-node-urls-from-chain-in-sdk-instead-of-using-hardcoded
Closed
Feature/lit 1815 pull node urls from chain in sdk instead of using hardcoded #245
Ansonhkg
wants to merge
261
commits into
master
from
feature/lit-1815-pull-node-urls-from-chain-in-sdk-instead-of-using-hardcoded
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…instead of throwing
…e-client-nodejs package
…st arrayify utf-16 strings
Signed-off-by: VoR0220 <catalanor0220@gmail.com>
joshLong145
reviewed
Nov 16, 2023
A hack was added a year ago to suppress a webpack complaint. Other packages import crypto and don't seem to contain this hack. The metro bundler doesn't allow for conditional requires / substitutions, and as such causes react-native to fail loading the crypto library. This PR removes the hack. I have not checked if webpack still complains but am hoping Chris can chime in.
joshLong145
reviewed
Nov 17, 2023
* feat: Store blockhash from handshake + use it in SIWE * feat: Pass blockhash instead of client in authSig functions * refac: Cleanup * feat: Client getter for blockhash + Manual tests * refac: Remove comments * refac: latest_blockhash -> latestBlockhash * test: Display result of manual tests * test: Node E2E test for creating authSig by fetching the blockhash from the client
…nto feature/lit-1815-pull-node-urls-from-chain-in-sdk-instead-of-using-hardcoded
…ad-of-using-hardcoded' of github.com:LIT-Protocol/js-sdk into feature/lit-1815-pull-node-urls-from-chain-in-sdk-instead-of-using-hardcoded
* it all works, yay * gen contracts * fix up tests * remove unused thing * add checkNodeAttestation boolean config option * better attestation * remove custom code to test on internaldev * check ip and port against report * check ip and port against attestation report * remove unused params * moving to get certs in js * i built stuff * it works * fully working in nodejs and also browser * fix valid cert test * sync package version * push readme changes * add back attestation checking from bad merge * add default for cayenne for attestation check * add explicit attestation check disable in e2e tests * fmt --------- Co-authored-by: Josh Long <josh@litprotocol.com>
…nto feature/lit-1815-pull-node-urls-from-chain-in-sdk-instead-of-using-hardcoded
Thanks for this work. closing as the implementations have been migrated to: #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage
yarn gen:internal-dev
To review
Scripts
Output
Integrations
Additionally
Test
yarn build
yarn test:e2e:node --filter=test-connection-internal-dev