Dynamic gas provider #2142
Merged
Dynamic gas provider #2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
|
Improves and provide features like priority over closed PR - #1856 |
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
gtebrean
reviewed
Feb 3, 2025
core/src/main/java/org/web3j/tx/gas/DynamicEIP1559GasProvider.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
f8c540a to
56e8805
Compare
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
|
only 2 comments, and resolve conflicts, rest is g2g |
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Signed-off-by: Nischal Sharma <nischal@web3labs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds support for Dynamic Gas Providers
Where should the reviewer start?
review all
Why is it needed?
Currently web3j only supports static and defaut gas Provider, which is not ideal in real world scenarios
Checklist