Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update public transactions #575

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

annamcallister
Copy link
Contributor

@annamcallister annamcallister commented Feb 20, 2025

Opening in draft so that I can get some feedback from Cheng ahead of being done.

The missing features I think this needs to be considered done are:

  • more validation that updates are valid/safe - particularly around gas pricing
  • recalculating gas estimate if transaction data has changed
  • Adding sub status updates to record values which have changed

I also need to spend some time thinking about whether there are any updates we want to allow which set a field back to nil or its default.

But I don't think any of these will change the overall structure and approach of the code.

Key points on the approach:

  • update is a best effort- return 200 once the changes are persisted into our DB, no promise of what will make it onto the chain
  • processing on previous values stops as soon as the changes are persisted, except to persist any work already done
  • All submissions are recorded, the comparing hashes with the receipt tells us which submission made it onto the chain

Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Signed-off-by: Anna McAllister <anna.mcallister@kaleido.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant