Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Infinite scrolling for registry #569

Merged
merged 7 commits into from
Feb 24, 2025
Merged

Infinite scrolling for registry #569

merged 7 commits into from
Feb 24, 2025

Conversation

gabriel-indik
Copy link
Contributor

@gabriel-indik gabriel-indik commented Feb 18, 2025

The registry view was one of the first panels built. In its first implementation, it would display all entries of all registries. The query limit for each of the registries was set to 100. This worked fine for development / testing purposes where the number of entries in the registry tends to be small. However, if the UI is used in an environment where the number of entries in the registry is in the hundreds or thousands, the user won't be able to access the full list.

For this reason the following changes were made:

  1. Instead of showing all entries from all registries, there is now a registry-selector control in the upper-left corner of the screen.
  2. Once a registry is selected (if there is just one, it is auto-selected) the entries are shown using infinite scrolling
  3. Toggle control has been added to view All | Active | Inactive registry entries
  4. Filters have been added in order to allow the user to quickly locate entries based on id, name and owner
  5. Filters are persisted using local storage
  6. Registry entries are sorted by name on the server side
image

Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
@gabriel-indik gabriel-indik marked this pull request as draft February 18, 2025 20:17
@gabriel-indik gabriel-indik self-assigned this Feb 18, 2025
@gabriel-indik gabriel-indik changed the title Infinity scrolling for registry Infinite scrolling for registry Feb 18, 2025
gabriel-indik and others added 4 commits February 18, 2025 16:25
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
@gabriel-indik gabriel-indik marked this pull request as ready for review February 20, 2025 14:16
Copy link
Contributor

@shorsher shorsher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📜 ♾️ 🚀

Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Copy link
Contributor

@dwertent dwertent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relying on @shorsher's approval

@gabriel-indik gabriel-indik merged commit c502948 into main Feb 24, 2025
6 checks passed
@gabriel-indik gabriel-indik deleted the registry-scale branch February 24, 2025 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants