Zeto lock support #545
Open
Zeto lock support #545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
…deposit/withdraw circuits Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
dwertent
reviewed
Feb 17, 2025
| } | ||
| req.AttestationResult[0].Payload = payload | ||
| _, err = h.Prepare(ctx, tx, req) | ||
| assert.NoError(t, err) |
There was a problem hiding this comment.
Suggested change
| assert.NoError(t, err) | |
| require.NoError(t, err) |
This will ensure the test won't panic in the event of an error
| @@ -102,7 +102,7 @@ func (h *depositHandler) Assemble(ctx context.Context, tx *types.ParsedTransacti | |||
| return nil, i18n.NewError(ctx, msgs.MsgErrorPrepTxOutputs, err) | |||
| } | |||
|
|
|||
| payloadBytes, err := h.formatProvingRequest(ctx, outputCoins) | |||
| payloadBytes, err := h.formatProvingRequest(ctx, outputCoins, (*tx.DomainConfig.Circuits)["deposit"]) | |||
There was a problem hiding this comment.
"deposit", "transfer", and similar values should likely be constants
| }, | ||
| } | ||
|
|
||
| var transferLockedABI_nullifiers = &abi.Entry{ |
There was a problem hiding this comment.
Suggested change
| var transferLockedABI_nullifiers = &abi.Entry{ | |
| var transferLockedABINullifiers = &abi.Entry{ |
I will suggest using the go naming convention
| // the Zeto implementations support two input/output sizes for the circuits: 2 and 10, | ||
| // if the input or output size is larger than 2, then the batch circuit is used with | ||
| // input/output size 10 | ||
| func getInputSize(sizeOfEndorsableStates int) int { |
There was a problem hiding this comment.
This function is implemented at common.GetInputSize
| return _utxosFromStates(ctx, states, desiredSize, false) | ||
| } | ||
|
|
||
| func _utxosFromStates(ctx context.Context, states []*prototk.EndorsableState, desiredSize int, isInputs bool) ([]string, error) { |
There was a problem hiding this comment.
Suggested change
| func _utxosFromStates(ctx context.Context, states []*prototk.EndorsableState, desiredSize int, isInputs bool) ([]string, error) { | |
| func utxosFromStates(ctx context.Context, states []*prototk.EndorsableState, desiredSize int, isInputs bool) ([]string, error) { |
Signed-off-by: Jim Zhang <jim.zhang@kaleido.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding support for the new zeto locking interface as described in hyperledger-labs/zeto#121
Caveat: