Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Key explorer UI #537

Merged
merged 19 commits into from
Feb 7, 2025
Merged

Key explorer UI #537

merged 19 commits into from
Feb 7, 2025

Conversation

gabriel-indik
Copy link
Contributor

@gabriel-indik gabriel-indik commented Jan 27, 2025

User experience:
Uses the combination of a breadcrumb and a paginated table in order to provide efficient navigation through a (potentially very big) set of keys that are hierarchically organized.

image

Clicking on the folder icons (with tooltip "Open folder") takes the user to different sections of the key hierarchy:

image

Reverse lookup:

image

Features to note:

  • Makes use of new key query API
  • Provides sorting by name | index, ascending | descending
  • Pagination is based on referenced key entries depending on sort field and order
  • Preference saved in local storage for:
    • Sort field
    • Sort order
    • Rows per page
  • Query string captures location within navigation

Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
@gabriel-indik gabriel-indik marked this pull request as draft January 27, 2025 15:31
@gabriel-indik gabriel-indik self-assigned this Jan 27, 2025
gabriel-indik and others added 6 commits January 28, 2025 16:04
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
@gabriel-indik gabriel-indik marked this pull request as ready for review January 29, 2025 21:25
gabriel-indik and others added 5 commits January 29, 2025 16:59
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

Couple of questions/observations - but none are explicit requests to change. Just to have a think about (maybe mostly wrt to what we do in future PRs that re-use this code).

However, there is something odd with the build due to the case change, which I don't know if it's just local to me.

gabriel-indik and others added 4 commits January 30, 2025 15:39
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Signed-off-by: Gabriel Indik <gabriel.indik@kaleido.io>
Copy link
Contributor

@peterbroadhurst peterbroadhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for working through all the questions 👍

@gabriel-indik gabriel-indik merged commit 8f2d97c into main Feb 7, 2025
6 checks passed
@gabriel-indik gabriel-indik deleted the key-explorer-ui branch February 7, 2025 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants