-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move validation configs to 8 GeV, intro reduced LDMX validation, add tracking to ecal pn #1385
Conversation
5571c59
to
fd1f2fa
Compare
…tracking to ecal pn
fd1f2fa
to
df25e7c
Compare
@tomeichlersmith is there anything I can do to generate gold for the reduced ldmx?
I realized this can be merged since the gold doesnt exists. |
The current design (which I'm not commited to but it is functional) is to have files follow specific naming conventions and then the CI detects what validation samples exist based off those assumptions. https://github.com/LDMX-Software/ldmx-sw/tree/trunk/.github/actions/validate#assumptions Both the gold-generation and the pr-validation use this action to run the samples so that they are run in the same way and they get which samples to include in generation/validation by simply using all directories within the https://github.com/LDMX-Software/ldmx-sw/tree/trunk/.github/actions/generate-matrix So, to add a new sample to be included in validation, the general procedure would be
This process is arduous but I couldn't think of anything better at the time. We can probably improve this but I'm not sure how many more validation samples we will want to include. I believe ee will quickly approach the computing limit of our free-tier GitHub workflows which is undesirable. |
Thanks Tom! I only miss steps 4-6 then, I'll commit those soon |
done now! also about the new version, maybe let's do it after I'm done with iss1387 (which I could do tomorrow [Tue]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me :)
I'm happy to add more tests and let them tell us where things are wonky.
@tomeichlersmith when I run the CI here
I'm a little bit confused since that file is added |
Ah yes I forgot, the golden files are retrieved from a checkout of trunk, so attempting to get a sample that is not on trunk yet will fail. A few paths forward
Edit: The |
OK makes sense thanks! |
I am updating ldmx-sw, here are the details.
What are the issues that this addresses?
Resolves #1384
Check List
This needs #1383 to be merged first. After that's done, I'll rebase