Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Align CODEOWNERS with agreed repo ownership #199

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

spikeheap
Copy link
Contributor

This change adds or updates CODEOWNERS to match the simplified
teams structure agreed in April 2024.

Why are we doing this?

We're doing this work to make any future restructure more straightforward,
simplify management of our GitHub, and move to team-based permission model
to ease joiners/movers/leavers.

This is step 3 in a 4-part consolidation:

  1. Add agreed teams to the repositories they own
  2. Bring team membership up-to-date
  3. Update CODEOWNERS to use the simplified teams (this PR)
  4. Remove old teams and individiduals from repositories

Effect of this change

This change won't have a practical effect on day-to-day work in GitHub.

In some cases more people will be able to approve a PR than previously,
where smaller sub-teams are reconciled into the high-level teams. In general
this is an acceptable risk as those people may be called upon to make changes,
however if the team feels the risk is too high we can create another team to
further restrict things as a subsequent piece of work.

Testing this PR

  1. Check the proposed change view, and confirm the CODEOWNERS file is marked
    as "valid".

Merging this PR

This PR is one of many, as we apply the same change to all our repositories.
Rather than expecting teams to merge these individually, we'll centrally check,
approve, and merge them as a batch, bypassing existing CODEOWNERS rules (because
many repositories have broken or out of date CODEOWNERS files).

To keep this safe @spikeheap will pair up with another engineer.

Copy link

@stonest stonest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤖 Bulk approved

@spikeheap spikeheap merged commit 57da966 into develop Jan 27, 2025
1 of 2 checks passed
@spikeheap spikeheap deleted the codeowners-2025 branch January 27, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants