Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auto arima #279

Merged
merged 34 commits into from
Jun 15, 2021
Merged

Auto arima #279

merged 34 commits into from
Jun 15, 2021

Conversation

guilhermebodin
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jun 9, 2021

Codecov Report

Merging #279 (a13f5d2) into master (c34b167) will decrease coverage by 1.16%.
The diff coverage is 78.15%.

❗ Current head a13f5d2 differs from pull request most recent head 3ac04a4. Consider uploading reports for the commit 3ac04a4 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   95.05%   93.88%   -1.17%     
==========================================
  Files          31       33       +2     
  Lines        2829     3043     +214     
==========================================
+ Hits         2689     2857     +168     
- Misses        140      186      +46     
Impacted Files Coverage Δ
src/models/basicstructural.jl 100.00% <ø> (ø)
src/models/basicstructural_explanatory.jl 98.97% <ø> (ø)
src/models/basicstructural_multivariate.jl 100.00% <ø> (ø)
src/models/dar.jl 96.55% <ø> (ø)
src/models/linear_regression.jl 100.00% <ø> (ø)
src/models/locallevel.jl 100.00% <ø> (ø)
src/models/locallevelcycle.jl 100.00% <ø> (ø)
src/models/locallevelexplanatory.jl 100.00% <ø> (ø)
src/models/locallineartrend.jl 100.00% <ø> (ø)
src/statistical_tests/canova_hensen.jl 0.00% <0.00%> (ø)
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 096c48c...3ac04a4. Read the comment docs.

Copy link
Member

@raphaelsaavedra raphaelsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I think there is some code being added that is not straightforward to understand and might be hard to maintain without comments

@@ -39,7 +39,7 @@ function forecast(
# Associate with the model hyperparameters
forecasting_model.hyperparameters = model_hyperparameters
# Perform the kalman filter
fo = kalman_filter(forecasting_model)
fo = kalman_filter(forecasting_model; filter = filter)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't look related to the PR, was it a bug?

@iagochavarry iagochavarry merged commit b1723e7 into master Jun 15, 2021
@guilhermebodin guilhermebodin deleted the auto_arima branch July 28, 2021 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants