Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add UC plot recipe #237

Merged
merged 1 commit into from
Feb 9, 2021
Merged

Add UC plot recipe #237

merged 1 commit into from
Feb 9, 2021

Conversation

guilhermebodin
Copy link
Member

It looks like this just by doing plot(model, ks). Closes #232
Captura de Tela 2021-02-08 às 21 31 47

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #237 (3930ba7) into master (7a24d1e) will decrease coverage by 0.20%.
The diff coverage is 85.41%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #237      +/-   ##
==========================================
- Coverage   93.74%   93.53%   -0.21%     
==========================================
  Files          24       25       +1     
  Lines        1886     1934      +48     
==========================================
+ Hits         1768     1809      +41     
- Misses        118      125       +7     
Impacted Files Coverage Δ
src/StateSpaceModels.jl 100.00% <ø> (ø)
src/models/unobserved_components.jl 87.33% <81.25%> (-0.46%) ⬇️
src/visualization/unobserved_components.jl 87.50% <87.50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a24d1e...3930ba7. Read the comment docs.

Copy link
Member

@raphaelsaavedra raphaelsaavedra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if we should think about having a separate StateSpacePlots package in order to avoid depending on Plots to improve compilation time of the package

@guilhermebodin
Copy link
Member Author

It does not depend on plots, it depends on RecipesBase, which is very light.

name = "RecipesBase"
uuid = "3cdcf5f2-1ef4-517c-9805-6587b60abb01"
author = ["Tom Breloff (@tbreloff)"]
version = "1.1.1"

[compat]
julia = "1"

[extras]
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"
Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"

[targets]
test = ["Test", "Random"]

@guilhermebodin guilhermebodin merged commit 757d55e into master Feb 9, 2021
@guilhermebodin guilhermebodin deleted the uc_viz branch April 2, 2021 00:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make Plot Recipes for Unobserved Components model
2 participants