-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Generate source for loaded snippets. #826
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a3dcbe7
to
9cef330
Compare
2a9a3bd
to
6596e95
Compare
(enabling lua is most likely a nop, since it is already available by default in newer neovim-versions)
I think we need a better explanation on what's going on that video. Do you generate new snippet from a selection or jump to the snippet definition? I'm puzzled. 🙄 |
😅😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is essentially another approach at storing a snippets source, less generic than #719, and only focused on source, not general metadata.
Major differences:
I've also written a pretty cool consumer for the metadata:
1678964272.mp4
It finds the range of the snippet via treesitter for lua and vscode, and fully via attached source-data (we know start and end of the snippet-definition since we do the parsing fully ourselves, and can thus provide this info) for snipmate
Missing: