Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with implementation of #53 #55

Closed
Kyslik opened this issue Mar 19, 2017 · 2 comments
Closed

Problem with implementation of #53 #55

Kyslik opened this issue Mar 19, 2017 · 2 comments
Assignees
Labels

Comments

@Kyslik
Copy link
Owner

Kyslik commented Mar 19, 2017

See 017d3ff#commitcomment-21388855 for more details.

@Kyslik Kyslik added the bug label Mar 19, 2017
@Kyslik Kyslik self-assigned this Mar 19, 2017
@ecodrutz
Copy link
Contributor

ecodrutz commented Mar 19, 2017

maybe we can replace strlen with a closure like:

function($el){
    return is_array($el) ? $el : strlen($el);
}

@Kyslik
Copy link
Owner Author

Kyslik commented Mar 19, 2017

Yep that might work, I will fix this tomorrow.

Thank you for suggestion (most likely I will use it).

@Kyslik Kyslik changed the title Problem with implementation of #54 Problem with implementation of #53 Mar 20, 2017
Kyslik added a commit that referenced this issue Mar 20, 2017
@Kyslik Kyslik closed this as completed in d5be2a0 Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants