include column title with request

[robbielove]

Hi,

I am trying to show the sort criteria and It would be nice if the 'title' used in the @sortablelink() was passed in the request in addition to sort and order so that it can be shown.

I am currently using ucfirst($request->sort), however this only works if the column name is the same as the title which in some cases will produce differences

[Kyslik]

You can send it yourself (see https://github.com/Kyslik/column-sortable#blade-extension)

@sortablelink('name', 'Username', ['title' => 'whatever you want'])

should generate:

/page?title=whatever%20you%20want

Also take a look at https://github.com/Kyslik/column-sortable/blob/L5.4/src/config/columnsortable.php#L67 you can set formatting_function.

---

If that is not what you meant explain further, otherwise just close :).

[robbielove]

I have used that to pass the request input (other filters etc) however it becomes problematic because the title parameters need to be merged with this request data array

I have tried
@sortablelink('id', 'ID', [$request->except(['title']),'title' => 'ID'])
and
@sortablelink('id', 'ID', array_add($request->except(['title']),'title','ID'))

which works for the first one but then somehow it will continue to use the first column selected (not removing the current title and replacing with the new one)

I have tested creating another link with just:
{{ route('users.index', array_add($request->except(['title']),'title','ID')) }}
{{ route('users.index', array_add($request->except(['title']),'title','Name')) }} etc,
as the href which works perfectly however obviously doesn't get the sortable value.

The sortable link for all headers still contains whatever the $request->title value is:
@sortablelink('name', 'Name', array_add($request->except(['title']),'title','ID'))
@sortablelink('name', 'Name', array_add($request->except(['title']),'title','Name')) etc

Which leads me to believe your function includes the wrong value where there are keys that match the request input. eg. if $request->title is set to TEST then the sortable link will contain:
/users?sort=id&order=asc&active=1&roles=member&title=TEST
/users?sort=name&order=asc&active=1&roles=member&title=TEST - from: @sortablelink('name', 'Name', array_add($request->except(['title']),'title','Name')) - but should show: /users?sort=slug&order=asc&active=1&roles=member&title=Name

I was kinda hoping avoid the double entry of the title, and having to merge the request array and exclude the request title adds to this burden. Although this may not be so bad if the link function worked as it should

using L5.2 branch

[Kyslik]

I kind of still do not understand what you are trying to achieve.

So you need for some kind of reason get parameter title so you can work with it later in controller?

I am trying to show the sort criteria and It would be nice if the 'title' used in the @sortablelink() was passed in the request in addition to sort and order so that it can be shown.

Gottcha! Now I understand.

---

What about

@sortablelink('name', 'Name', ['title' => 'Name'])

---

I might try to add config value in order to set boolean value if user want to inject title in request.

[robbielove]

I might try to add config value in order to set boolean value if user want to inject title in request.

that is pretty much what I was after
@sortablelink('name', 'Name', $request->except(['title']), true))
@sortablelink(column, title, pass parameter, pass/merge title))

[Kyslik]

Its done, I just push new release after test pass.

[robbielove]

I have implemented your changes and it seems to be working perfectly, thank you so much 😊

[Kyslik]

No problem. Have a good artisan adventures.