Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release 5.1.0 refactor causes trans() helper to fail when used as 2nd param of @sortablelink directive #36

Closed
jj-meyer opened this issue Sep 8, 2016 · 3 comments
Closed

Release 5.1.0 refactor causes trans() helper to fail when used as 2nd param of @sortablelink directive #36

jj-meyer opened this issue Sep 8, 2016 · 3 comments

Comments

@jj-meyer
Copy link

jj-meyer commented Sep 8, 2016

When using the Laravel translate helper trans() as the second parameter of the @sortablelink() directive, in release 5.1.0, the literal is returned, not the result of the function.

This worked correctly in release 5.0.9, prior to the refactor.

Example: @sortablelink('segment_name',trans('entities.segment_segment_name'))
@Kyslik
Copy link
Owner

Kyslik commented Sep 8, 2016 •
edited
Loading

Will fix this tonight, thank you for informing me!
Just use 5.0.9 for now.

Kyslik added a commit that referenced this issue Sep 8, 2016
@Kyslik
Fix issue #36, now accepting ' and ", formating functions can be passed
f446f28 
@sortablelink("id", trans('column-sortable.id'))
@sortablelink("name", "Name")
@sortablelink('email')
@sortablelink('detail.phone_number', trans('column-sortable.phone'))
@Kyslik
Copy link
Owner

Kyslik commented Sep 8, 2016 •
edited
Loading

Should be fixed in 5.1.1.

Thanks

@Kyslik Kyslik closed this as completed Sep 9, 2016
@jj-meyer
Copy link
Author

Perfect. Sorted, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Kyslik @jj-meyer