implemented kyberPMM is the same #380
Open
+21
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hieuvo
reviewed
Mar 8, 2024
| if len(p1) != len(p2) { | ||
| return false | ||
| } | ||
| priceMap := make(map[float64]float64, len(p1)) |
There was a problem hiding this comment.
be careful as handling float numbers
https://goplay.space/#E4wWkMLU1n_w
There was a problem hiding this comment.
@cyberliem levels not need to be ordered, actually we usually give bad price at the first level(due gas fee).
I think compare two price levels by asks vs asks, bids vs bids, and they are slices, so you can do slice compare.
in theory, [{qty: 1, price 0.5}, {qty: 1, price: 0.49}] is different with [{qty: 1, price: 0.49}, {qty: 1, price 0.5}]
because we apply it from top -> end
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
We need a way to tell if the kyberPMM is updated or not (by comparing new state to the old received one)
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):