Support RxJava3 #6
Merged
+81
−72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
irgaly
commented
Aug 5, 2021
- v0.2.0
- compileSdk 30
- RxJava3
- Gradle 7.1.1
- AGP 7.0.0
- Kotlin 1.5.21
k-kagurazaka
reviewed
Aug 6, 2021
| classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin" | ||
| classpath "com.github.dcendents:android-maven-gradle-plugin:2.0" | ||
| classpath 'com.github.triplet.gradle:play-publisher:2.8.0' |
There was a problem hiding this comment.
これも上げないと多分AGP7でビルド通らないと思います。
There was a problem hiding this comment.
example アプリが起動できるところまで確認しています。
古いライブラリ・使われていないライブラリは今回は最低限ビルドを通すためにバージョンアップしています
There was a problem hiding this comment.
なるほど。Playストアにアップロードしようと思うとエラーになるのかしら。
いったん大丈夫です！
| @@ -63,15 +63,12 @@ play { | |||
| dependencies { | |||
| implementation project(':library') | |||
|
|
|||
| //==================== Kotlin ==================== | |||
| implementation "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin" | |||
|
|
|||
| //==================== Support Library ==================== | |||
| implementation "com.android.support:appcompat-v7:$supportLibrary" | |||
| implementation "com.android.support:design:$supportLibrary" | |||
There was a problem hiding this comment.
example 側だったので今回は触れずにおいています。
There was a problem hiding this comment.
ほんとだ、example側でしたね。OKです！
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.