Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NodeBundle] Refactor online template #520

Merged
merged 1 commit into from
Aug 18, 2015
Merged

[NodeBundle] Refactor online template #520

merged 1 commit into from
Aug 18, 2015

Conversation

denbatte
Copy link
Contributor

@denbatte denbatte commented Jul 2, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets

If you wanted to use the 'online template' from the nodebundle, you had to convert the 0 or 1 boolean in database to "true" or "false" strings using.

public function getValue($item, $columnName)
{
    if ($columnName == 'online') {
        return $item['online'] ? 'true' : 'false';
    }

    return parent::getValue($item, $columnName);
} 

This is not needed if you just check for the boolean type true or false in the template, and not the string type.

@denbatte denbatte changed the title [NodeBundle] Refactor online template [WIP] [NodeBundle] Refactor online template Jul 6, 2015
@denbatte denbatte changed the title [WIP] [NodeBundle] Refactor online template [NodeBundle] Refactor online template Aug 4, 2015
@roderik roderik added this to the 3.3.0 milestone Aug 15, 2015
roderik pushed a commit that referenced this pull request Aug 18, 2015
@roderik roderik merged commit f2dcae9 into Kunstmaan:master Aug 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants