Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MediaBundle] Add priority to media handlers #394

Merged
merged 1 commit into from
May 5, 2015

Conversation

arneruy
Copy link
Contributor

@arneruy arneruy commented May 5, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #188

Handlers with higher priority will be preferred over handlers with lower priority when adding media.

@krispypen
Copy link
Contributor

@arneruy can you check the travis build log?

@arneruy arneruy force-pushed the issue_188 branch 4 times, most recently from 0bb5b96 to b0bb096 Compare May 5, 2015 14:44
Update tests

Update tests

Update tests

Update tests
roderik pushed a commit that referenced this pull request May 5, 2015
[MediaBundle] Add priority to media handlers
@roderik roderik merged commit 205f11d into Kunstmaan:master May 5, 2015
@roderik roderik added this to the 3.1.1 milestone May 5, 2015
@wimvds
Copy link
Contributor

wimvds commented May 13, 2015

Why don't we use standard Symfony behavior for this? ie. (optionally) add a priority to the tag of the handler in the config, and sort handlers according to that priority, just like the kunstmaan_admin.menu.adaptor handling.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants