Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AdminBundle, GeneratorBundle, UserManagementBundle] Remove default hardcoded admin/admin #382

Merged
merged 1 commit into from
Jun 3, 2015

Conversation

arneruy
Copy link
Contributor

@arneruy arneruy commented Apr 29, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? yes the default admin login is not available anymore, a password is generated
Deprecations? no
Fixed tickets #194

DataFixtures to create default roles, groups and users have been transferred to the GeneratorBundle.
The default admin user now has a randomly generated password which is displayed after loading the UserFixtures. This password will also be saved in app/config.yml .

screen shot 2015-04-29 at 15 29 31

Users now have an extra variable password_changed. This is set to 0 if it's password has been generated. After logging in for the first time, the user is redirected to the FOS change-password page. Changing the password will set password_changed to 1.

screen shot 2015-04-29 at 14 40 55

screen shot 2015-04-29 at 15 37 11

  • Finish the feature
  • Gather feedback for my changes
  • Submit changes to the documentation
  • Update behat tests

@kimausloos
Copy link
Contributor

Nice feature! 2 Minor remarks:

  • I would make the generated password 8 characters
  • I would make the check to see if the admin changed his password configurable (default true), and for all admin routes.
    But you should discus this @krispypen too

@krispypen krispypen added this to the 3.2.0 milestone May 4, 2015
@arneruy arneruy force-pushed the issue_194 branch 4 times, most recently from f21e9ad to abbe102 Compare May 8, 2015 11:33
@roderik roderik changed the title [WIP] [AdminBundle, GeneratorBundle, UserManagementBundle] Remove default hardcoded admin/admin [AdminBundle, GeneratorBundle, UserManagementBundle] Remove default hardcoded admin/admin Jun 2, 2015
@roderik
Copy link
Contributor

roderik commented Jun 2, 2015

@arneruy rebase -f, rebase -i, en uitleg uit deze pull request toevoegen aan UPGRADE-3.2

@arneruy arneruy force-pushed the issue_194 branch 2 times, most recently from 2bcbbe0 to ae81112 Compare June 3, 2015 10:59
Add PasswordResettingListener

echo new password

add ok button

fix styling echo password

update behat

refactor UserFixtures

Check on all admin routes

update phpdocs

refactor admintests

Sepate tests

Update documentation
roderik pushed a commit that referenced this pull request Jun 3, 2015
[AdminBundle, GeneratorBundle, UserManagementBundle] Remove default hardcoded admin/admin
@roderik roderik merged commit 30befa6 into Kunstmaan:master Jun 3, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants