[GeneratorBundle] Fix error when generating pagepart with images #356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,13 +31,13 @@ public function buildForm(FormBuilderInterface $builder, array $options) | |||
| {% endif %} | |||
| {% if field.mediaType is defined and field.mediaType != 'none' %} 'mediatype' => '{{ field.mediaType }}', | |||
| 'constraints' => array(new Assert\Media(array( | |||
| 'mimeTypes' => array({% for type in field.mimeTypes %}'{{ type }}',{% endfor %}), | |||
| 'mimeTypes' => array({% for type in field.mimeTypes %}'{{ type }}',{% endfor %}), | |||
There was a problem hiding this comment.
can you remove this file from your PR? never use "git add ."
|
@arne zet uw gitconfig eens juist? |
d605618 to
f83965b
Compare
Fix error when generating pagepart Revert "Fix error when generating pagepart" This reverts commit edd710b. Fix error when generating pagepart Fix error when generating pagepart
|
@roderik 👍 |
roderik
pushed a commit
that referenced
this pull request
Apr 22, 2015
[GeneratorBundle] Fix error when generating pagepart with images
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pageparts containing images can now be generated without errors.