[NodeBundle, GeneratorBundle] Deprecated the service method in Pages in favour of controller methods

[woutervandamme]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	yes
Fixed tickets	#211

instead of putting logic in the entity pages (service method), it is now possible to just implement the SlugActionInterface and specify which controller method must be executed.

• Gather feedback for my changes
• update relevant CHANGELOG and UPGRADE files;

UPGRADE

Deprecated the service method in Pages in favour of controller methods

You need to remove the service method in your entities and replace them by implementing the SlugActionInterface. Add the method getControllerAction and make it return a callable string.

    public function getControllerAction()
    {
        return 'Bundle:Controller:service';
    }

In your controller just add the serviceAction method, let it handle the logic and set the renderContext in the request attributes.

    public function serviceAction(Request $request)
    {
        ..logic..
        $context['variable'] = $variable;

        $request->attributes->set('_renderContext',$context);
    }

[roderik]

after open tasks and squash, 👍 for merge

[krispypen]

@woutervandamme :)

[wimvds]

Check the Symfony coding standards for correct code structure (http://symfony.com/doc/current/contributing/code/standards.html - or format your code automatically in your IDE using Symfony coding standards :p).