[MediaBundle] Paginate Image thumbnail view to 24 images (6 rows of 4) per page #1633
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
delboy1978uk
commented
Nov 6, 2017
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | #1632 |
cv65kr
suggested changes
Nov 6, 2017
| @@ -113,12 +120,24 @@ public function canDelete($item) | |||
| /** | |||
| * @return int | |||
| */ | |||
| public function getLimit() | |||
| public function getLimit() : int | |||
There was a problem hiding this comment.
BC break for PHP version lower than 7.0
| * @param int $limit | ||
| * @return MediaAdminListConfigurator | ||
| */ | ||
| private function setLimit(int $limit): MediaAdminListConfigurator |
There was a problem hiding this comment.
This is branching from 5.0, which is targeting PHP 7. I asked @Numkil before I committed.
There was a problem hiding this comment.
Ok, I understand but in composer we have version PHP >=5.6.0 so this case create BC break. In milestones on version 6.0 (#1445) we start using PHP 7.1 version skipped PHP 7.0 :)
There was a problem hiding this comment.
ok i'll remove the return types then :-)
sandergo90
suggested changes
Nov 24, 2017
| @@ -51,6 +54,10 @@ public function __construct( | |||
|
|
|||
| $this->folder = $folder; | |||
| $this->request = $request; | |||
|
|
|||
| // Thumbnail view should display 24 images, list view 250 | |||
| $viewMode = $request->get('viewMode'); | |||
There was a problem hiding this comment.
When no view mode is in the request query, it will still display 250 items but the default viewMode is thumbnail.
| @@ -32,6 +32,9 @@ class MediaAdminListConfigurator extends AbstractDoctrineORMAdminListConfigurato | |||
| */ | |||
| private $request; | |||
|
|
|||
| /** @var int $limit */ | |||
There was a problem hiding this comment.
Can you add the doc on multiple lines like the variables above?
| * @param int $limit | ||
| * @return MediaAdminListConfigurator | ||
| */ | ||
| private function setLimit($limit) |
There was a problem hiding this comment.
Do we need a setter for this ? Can't we just do $this->limit = 24 ?
|
Also @delboy1978uk , this is no BC, so master branch 😉 |
|
Rebasing to master, will push up shortly! |
303d180 to
82726c2
Compare
|
rebased! 👍😀 |
sandergo90
approved these changes
Nov 24, 2017
dbeerten
pushed a commit
to dbeerten/KunstmaanBundlesCMS
that referenced
this pull request
Dec 7, 2017
…nstmaan#1633) [MediaBundle] Paginate Image thumbnail view to 24 images (6 rows of 4) per page
Devolicious
added a commit
that referenced
this pull request
Dec 14, 2017
* master: (33 commits) [NodeBundle] vixed error bubbling for URLChooser [UtilitiesBundle] Using Symfony Process in Shell Class [RedirectBundle] Stop duplicate origins for single domain redirects [FormBundle] Make label non nullable in abstract form page part and assert not blank [AdminBundle] Hide wrapping content of large value fix styling of reset password form [GeneratorBundle]: fix classes in fields.html.twig [RedirectBundle] Ability to redirect for eg. /whatever/* to /something-else/* [UtilitiesBundle] Cipher deprecations (#1673) [MediaBundle] - Use JsonResponse to set headers instead of calling header() [FormBundle] Default file upload label required to false [MediaBundle] Include filters even if no results found [AdminBundle] remove hard coded 'validators' from twig view version bump moment js [MultiDomainBundle] Cache previously fetched node translations in array property [SearchBundle] add punctuation to kuma_ngram tokenizer Paginate Image thumbnail view to 24 images (6 rows of 4) per page (#1633) Remove alias functions usage by using the original functions Remove double (unnecessary) semicolon 'static::incrementString(...)' should be used instead. ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.