[KunstmaanAdminBundle]: fix nested forms #1574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[KunstmaanAdminBundle]: Change nested forms prototypes Remove duplicate content
Numkil
approved these changes
Nov 15, 2017
Devolicious
approved these changes
Dec 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When having a collection form type inside another collection type with the "Add new" button it will not work because the replace of the prototype for the nested collection is already done in the replace of the parent prototype so you will get a javascript error.
Solution is to only change the parts of the current collection.
If someone has a better solution for this, or a nicer way, please say so ;)
@Devolicious is it also a BC-break by introducing the data-prototype-name here ?