Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AdminBundle] Added optional password restrictions #1473

Merged
merged 1 commit into from
Jun 28, 2017
Merged

[AdminBundle] Added optional password restrictions #1473

merged 1 commit into from
Jun 28, 2017

Conversation

deZinc
Copy link
Contributor

@deZinc deZinc commented Mar 6, 2017 •
edited
Loading

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets #1469

To set the optional parameters for the password restrictions, in app/config.yml:

kunstmaan_admin:
    password_restrictions:
        min_digits: 2
        min_uppercase: 2
        min_special_characters: 1
        min_length: 8
        max_length: 15

TODO:

  • Submit changes to the documentation

@deZinc deZinc changed the title [AdminBundle] Added optional password restrictions [AdminBundle] Added optional password restrictions (wip) Mar 7, 2017
jockri
jockri reviewed Mar 7, 2017
View reviewed changes
src/Kunstmaan/AdminBundle/DependencyInjection/Configuration.php
->integerNode('min_uppercase')->defaultNull()->end()
->integerNode('min_special_characters')->defaultNull()->end()
->integerNode('min_length')->defaultNull()->end()
->integerNode('max_length')->defaultNull()->end()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to limit the password lenght

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The limit of the the password length is optional, so it's not necessary to set it.
(All restrictions are optional.)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why would you encourage anyone to set a maximum password length (by providing this option)? Please don’t! @jockri made a great point!

@Devolicious Devolicious added this to the 4.1.0 milestone Jun 28, 2017
@Devolicious Devolicious changed the title [AdminBundle] Added optional password restrictions (wip) [AdminBundle] Added optional password restrictions Jun 28, 2017
@Devolicious Devolicious merged commit e5ada00 into Kunstmaan:master Jun 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jockri jockri jockri left review comments

@mlebkowski mlebkowski mlebkowski left review comments

@Devolicious Devolicious Devolicious approved these changes

Assignees
No one assigned
Labels
Priority: Low Profile: Backend Target audience: Administrators Type: Feature Type: Roadmap
Projects
None yet
Milestone
4.1.0
Development

Successfully merging this pull request may close these issues.
4 participants
@deZinc @Devolicious @jockri @mlebkowski