Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PagePartBundle]: make page variable available inside pagepart admin #1424

Merged
merged 1 commit into from
Jan 5, 2017
Merged

[PagePartBundle]: make page variable available inside pagepart admin #1424

merged 1 commit into from
Jan 5, 2017

Conversation

sandergo90
Copy link
Contributor

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets

We are using the page variable very frequently inside our pagepart twig templates. The page variable is not available when editing a node. Therefor you need to create a admin view template for this issue. By adding the page variable always, we can use it also in the admin views.

@Numkil
Copy link

Numkil commented Jan 4, 2017

Is it possible to also make the variable "node" which is the current node available? Seems like we use it often as well.

@sandergo90
Copy link
Contributor Author

@Numkil that's not possible for now. The pageparts are rendered with a twig extensions with no knowledge of the current node at that moment.

@sandergo90 sandergo90 changed the base branch from 4.0 to master January 5, 2017 13:47
@Devolicious Devolicious merged commit 9cebf3e into Kunstmaan:master Jan 5, 2017
@sandergo90 sandergo90 deleted the feature/pagepartadmin branch January 5, 2017 14:06
@Devolicious Devolicious added this to the 4.1.0 milestone Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants