Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ConfigBundle] Fixed variable name, in routing and view, for ConfigController::indexAction. #1419

Merged
merged 1 commit into from
Dec 20, 2016
Merged

[ConfigBundle] Fixed variable name, in routing and view, for ConfigController::indexAction. #1419

merged 1 commit into from
Dec 20, 2016

Conversation

adrianwaler
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets #1418

sandergo90
sandergo90 suggested changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@sandergo90 sandergo90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to change the internal_name in the ConfigController

composer.json
@@ -94,7 +94,7 @@
},
"extra": {
"branch-alias": {
"dev-master": "4.0-dev"
"dev-master": "4.1-dev"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't commit this please

@adrianwaler
Copy link
Contributor Author

@sandergo90 Internal name was changed here 0cd0239 and that's why it now don't work properly. More about you can read in #1418

@sandergo90
Copy link
Contributor

Hi @adrianwaler Yes I know ;) My comment is on the part of dev-master that you are trying to commit. And "Don't forget to change the internal_name in the ConfigController".

Cheers

@adrianwaler adrianwaler force-pushed the issue_1418 branch 2 times, most recently from 4475f31 to 1d68796 Compare December 20, 2016 14:01
@sandergo90
Copy link
Contributor

@adrianwaler last think, can you update your commit message to "ConfigBundle" instead of "ConfigBunlde" ? ;)

Cheers

@adrianwaler
Copy link
Contributor Author

@sandergo90 I got it ^^ I don't know why I didn't find it earlier.

Yeah sure, I'll change it. Thanks!

@adrianwaler adrianwaler changed the title [ConfigBunlde] Fixed variable name, in routing and view, for ConfigController::indexAction. [ConfigBundle] Fixed variable name, in routing and view, for ConfigController::indexAction. Dec 20, 2016
sandergo90
sandergo90 approved these changes Dec 20, 2016
View reviewed changes
Copy link
Contributor

@sandergo90 sandergo90 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Devolicious review done, waiting for green tests ;)

@Devolicious Devolicious merged commit 6857fdc into Kunstmaan:4.0 Dec 20, 2016
@Devolicious Devolicious added this to the 4.0.1 milestone Jan 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sandergo90 sandergo90 sandergo90 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@adrianwaler @sandergo90 @Devolicious