[MediaBundle]: check if file exists #1396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aistis-
reviewed
Dec 9, 2016
| @@ -80,7 +80,7 @@ public function preUpdate(PreUpdateEventArgs $eventArgs) | |||
| if ($deleted || $reverted) { | |||
| $oldFileUrl = $entity->getUrl(); | |||
| $newFileName = ($reverted ? $entity->getOriginalFilename() : uniqid()); | |||
| $newFileUrl = dirname($oldFileUrl) . '/' . $newFileName . '.' . pathinfo($oldFileUrl, PATHINFO_EXTENSION); | |||
| $newFileUrl = dirname($oldFileUrl).'/'.$newFileName.'.'.pathinfo($oldFileUrl, PATHINFO_EXTENSION); | |||
There was a problem hiding this comment.
Why we are changing code style fort dot operand wrapping? :)
There was a problem hiding this comment.
Because that's the coding standard ;)
Add a single space around binary operators (==, &&, ...), with the exception of the concatenation (.) operator;
| if ($handler->fileSystem->has($originalFileName)) { | ||
| $handler->fileSystem->rename( | ||
| $originalFileName, | ||
| preg_replace('~^'.preg_quote($handler->mediaPath, '~').'~', '/', $url) |
Remove duplicate entries
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When deleting a file that no longer exists on the filesystem you will get an error that the file does not exists. This check will verify that the file exists on the filesystem and will not do the rename action when it does not exists. This way the delete process can continue.