[AllBundles] Update default form types #1353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dannyvw
commented
Oct 22, 2016
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets |
jockri
reviewed
Oct 23, 2016
| 'label' => 'kuma_form.form.page_admin.subject.label', | ||
| )); | ||
| $builder->add('from_email', null, array( | ||
| $builder->add('from_email', TextType::class, array( |
There was a problem hiding this comment.
Changed to EmailType
jockri
reviewed
Nov 2, 2016
| 'label' => 'kuma_form.form.page_admin.from_email.label', | ||
| )); | ||
| $builder->add('to_email', null, array( | ||
| $builder->add('to_email', EmailType::class, array( |
There was a problem hiding this comment.
This should be texttype? Currently it is possible to pass a comma delimited string of emails
4d0b2b2 to
b6af588
Compare
b6af588 to
112ff1a
Compare
Devolicious
added a commit
that referenced
this pull request
Aug 1, 2017
* master: [AllBundles] Update default form types (#1353) Fix phpunit tests for translator bundle Add php 7.1 to travis remove .sublime-project file Fix audio display if media type isn't soundcloud Check if page implements HasPageTemplateInteface methods Inject only needed service instead of full container Add form isSubmitted before isValid
cv65kr
pushed a commit
to cv65kr/KunstmaanBundlesCMS
that referenced
this pull request
Nov 17, 2017
* Fix form types * Change to email type
dbeerten
pushed a commit
to dbeerten/KunstmaanBundlesCMS
that referenced
this pull request
Dec 7, 2017
* Fix form types * Change to email type
delboy1978uk
added a commit
to delboy1978uk/KunstmaanBundlesCMS
that referenced
this pull request
Dec 13, 2017
* 4.0: (51 commits) [NodeSearchBundle]: check if we have html [NodeSearchBundle] shards and replicas configurable Upgrade to latest LiipImagine bundle [Docs]: add anacrontab documentation and fix numbering of docs [AllBundles]: add crowdin as translator [AdminListBundle] Fixed doctrine Index for LockableEntity (Kunstmaan#1654) Gitattributes (Kunstmaan#1557) [AdminListBundle] Incorrect logic checking if version lock is active [KunstmaanAdminListBundle]: fix abstract page admin list Crawler for removing style and script tags Fix docblock so child entities fluent setters wont break revert fix Kunstmaan#1562 with new solution [AllBundles] Update default form types (Kunstmaan#1353) Fix phpunit tests for translator bundle Add php 7.1 to travis remove .sublime-project file Check if page implements HasPageTemplateInteface methods [KunstmaanAdminListBundle]: add new event subscriber [KunstmaanAdminListBundle]: always get latest overviewpage [KunstmaanPagePartBundle]: check if add pagepart button is the first one ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.