[TranslatorBundle]: Scale textarea to content #1337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
indentation fix is correct, space between function and () needs to be reverted. |
Devolicious
reviewed
Oct 12, 2016
| var $field = $(this); | ||
| var $width = $field.width(); |
There was a problem hiding this comment.
vars only start with $ when it is a jQuery object
15c325d to
fde8921
Compare
diskwriter
reviewed
Oct 12, 2016
| @@ -9,6 +9,11 @@ kunstmaanTranslatorBundle.inlineEdit = (function(window, undefined) { | |||
|
|
|||
| $('.js-editable').each(function() { | |||
| var $field = $(this); | |||
| var width = $field.width(); | |||
|
|
|||
| $($field).on('shown', function(e, editable) { | |||
There was a problem hiding this comment.
No need to double wrap $field here. $field is already a jQuery object
Remove spaces Fix double wrap
fde8921 to
5e5b1b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scale textareas to the content that is being edited.
Textarea was too small for the content.