[SeoBundle] Catch exception when OG image no longer exists #1324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aistis-
reviewed
Oct 10, 2016
| try { | ||
| list($width, $height) = getimagesize($src); | ||
| } catch (\Exception $e) { | ||
| return false; |
There was a problem hiding this comment.
I think return null is more convenient :)
aistis-
approved these changes
Oct 10, 2016
bakie
reviewed
Oct 11, 2016
| } catch (\Exception $e) { | ||
| return null; | ||
| } | ||
|
|
There was a problem hiding this comment.
why not do a check with file_exists ?
if (file_exists($src)) {
list($width, $height) = getimagesize($src);
return array('width' => $width, 'height' => $height);
}
return null;
There was a problem hiding this comment.
@bakie Sure, that's possible. Not sure about the exact performance of those two functions, but wouldn't that just hit the disk a second time for the same thing getimagesize would already do?
There was a problem hiding this comment.
bare in mind that the file can be stored on a remote server. I turned this feature altogether since my media files are stored in a S3 bucket
There was a problem hiding this comment.
@mlebkowski Yes, we sometimes have the same issue. Not sure it's worth the disk read when it's stored locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the selected ogImage is no longer present on disk,
get_image_dimensionswill throw an exception.