Fix redirect add admin action and possible others. #127
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed the 'Add Redirect' action was broken in the admin interface (illegal offset error), and it turns out the
RedirectAdminListController
makes a wrong call toAdminListController::doAddAction
[1].This was also the case in some other controllers, which I also fixed.
But the method signature has
$type
as the second parameter:the third
@param
is missing btwWe could also add a check in the
doAddAction
method, but that seems very ugly and a bit unnecessary.