[NodeBundle] link select language problem

[slaci]

Q	A
Bug fix?	yes
New feature?	no
BC breaks?	no
Deprecations?	no
Fixed tickets	#1159

Uses the "multilanguage" twig global variable to control the base url. This is not defined by default (and consistently can only be defined in the standard edition), so when the variable is missing, then the old behavior applies (generates locale aware base urls, like multilanguage == true).

Generating urls with routing would be much better, but its not that simple.

The multilanguage variable should come from this: Kunstmaan/KunstmaanBundlesStandardEdition#208

[mlebkowski]

Generating urls with routing would be much better, but its not that simple.

Why? How about path("_slug", { "_locale": lang, "url": "REPLACE_ME" }) and then use this as a placeholder instead of a prefix?

[slaci]

Because if some1 selects a link in dev mode, then the link will contain app_dev.php, and that will be saved into the db. Its ofc not recommended to upload content in dev mode for prod usage, but this is not unlikely to happen I think...
There is no easy way to generate prod url in symfony from a different env afaik... only if you dualboot somehow a prod appkernel maybe... seems very big overhead, but the cleanest.
The other way is the hax, when just use str_replace and dontcare.. but I don't want to push something like that (I pasted an example into the linked issue for this) :P

[mlebkowski]

wow, I didn’t realize that symfony would add /app_dev.php prefix if the rewrite is not configured.

on a side note, storing urls in the db is fragile either way — they won’t update when the NodeTranslation changes. This is why we created a url to NodeTranslation transformer and used it to extend the behaviour of UrlChooser. This way the interface stays the same, but the database stores a reference to NodeTranslation instead of a string with url.

[jockri]

I would use path("_slug", { "_locale": lang, "url": "" }). Then no replace is needed.

A couple of weeks ago, we moved the url generating outside of the recursive loop because it was becoming a bottleneck. In the previous bundle versions, the app_dev.php was also added in dev mode.

I agree that it would be better to store a reference in the database, and generate te link on the fly when needed. This was something we have discussed internally and it should be added to the roadmap.

[mlebkowski]

I would use path("_slug", { "_locale": lang, "url": "" }). Then no replace is needed.

You assume that the _slug route is like /{_locale}/{url}, but in fact it can be changed so that the url is not a simple prefix. This is why I suggested a "REPLACE_ME" approach.

[mlebkowski]

And — yes — your solution would work out of the box now w/o any more changes needed, IIRC

[jockri]

closed in favor of #1223