Skip to content

Commit

Permalink
Merge pull request #461 from denbatte/feature/insightsNodeBundle
Browse files Browse the repository at this point in the history
[NodeBundle] fixes Sensiolabs insight issues on Nodebundle
  • Loading branch information
Roderik van der Veer committed Jun 2, 2015
2 parents 50829c5 + fceab99 commit c1aa697
Show file tree
Hide file tree
Showing 6 changed files with 5 additions and 10 deletions.
2 changes: 1 addition & 1 deletion src/Kunstmaan/NodeBundle/Event/SlugEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,4 @@ public function setRenderContext(RenderContext $renderContext)
{
$this->renderContext = $renderContext;
}
}
}
2 changes: 1 addition & 1 deletion src/Kunstmaan/NodeBundle/Event/SlugSecurityEvent.php
Original file line number Diff line number Diff line change
Expand Up @@ -12,4 +12,4 @@
final class SlugSecurityEvent extends Event
{

}
}
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ private function setSlugWhenEmpty(NodeTranslation $nodeTranslation, EntityManage
/**
* If no slug is set and no structure node, apply title as slug
*/
if ($nodeTranslation->getSlug() == null && $nodeTranslation->getNode()->getParent() != null) {
if ($nodeTranslation->getSlug() === null && $nodeTranslation->getNode()->getParent() !== null) {
$nodeTranslation->setSlug($this->slugifier->slugify($nodeTranslation->getTitle()));
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/Kunstmaan/NodeBundle/EventListener/SlugListener.php
Original file line number Diff line number Diff line change
Expand Up @@ -74,4 +74,4 @@ public function onKernelController(FilterControllerEvent $event)
$event->setController($this->resolver->getController($request));
}
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ public function onSlugSecurityEvent()

$this->request->attributes->set('_nodeMenu', $nodeMenu);
}
}
}
5 changes: 0 additions & 5 deletions src/Kunstmaan/NodeBundle/Helper/NodeMenu.php
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@
class NodeMenu
{

/***** constructor arguments *****/

/**
* @var EntityManager
*/
Expand Down Expand Up @@ -59,9 +57,6 @@ class NodeMenu
*/
private $includeHiddenFromNav = false;


/***** temporary storage variables *****/

/**
* @var NodeMenuItem[]
*/
Expand Down

0 comments on commit c1aa697

Please sign in to comment.