Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Fixed a warning reported by CMake #11773

Merged
merged 1 commit into from
Nov 7, 2023
Merged

[Core] Fixed a warning reported by CMake #11773

merged 1 commit into from
Nov 7, 2023

Conversation

avdg81
Copy link
Contributor

@avdg81 avdg81 commented Nov 6, 2023

📝 Description
The cmake_minimum_required() command should be called at the beginning of the top-level CMakeLists.txt file even before calling the project() command.

🆕 Changelog
Swapped the cmake_minimum_required() and project() commands in the top-level CMakeLists.txt file.

@avdg81
Fixed a warning reported by CMake
688ab7d 
The `cmake_minimum_required()` command should be called at the beginning
of the top-level `CMakeLists.txt` file even before calling the
`project()` command.
@avdg81 avdg81 self-assigned this Nov 6, 2023
@avdg81 avdg81 requested a review from a team as a code owner November 6, 2023 16:37
@avdg81 avdg81 linked an issue Nov 6, 2023 that may be closed by this pull request
[Core] CMake warning about calling cmake_minimum_required() before calling the top-level project() #11772
Closed
@avdg81 avdg81 added the FastPR This Pr is simple and / or has been already tested and the revision should be fast label Nov 6, 2023
roigcarlo
roigcarlo approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@roigcarlo roigcarlo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@avdg81 avdg81 merged commit 794c315 into master Nov 7, 2023
10 of 11 checks passed
@avdg81 avdg81 deleted the 11772-fix-cmake-warning branch November 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roigcarlo roigcarlo roigcarlo approved these changes

Assignees

@avdg81 avdg81

Labels
CMake FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core] CMake warning about calling cmake_minimum_required() before calling the top-level project()
2 participants
@avdg81 @roigcarlo