Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core][MPI] Reorganize testing utilities #11553

Merged
merged 5 commits into from
Sep 12, 2023
Merged

Conversation

roigcarlo
Copy link
Member

📝 Description
Revised the way cpp tests files and dependencies are compiled both in serial and mpi to solve dependency problems.

Fixes #11548
Implements part of #11506

🆕 Changelog

  • Auxiliary files for testing are move outside the cpp test folder.
  • Auxiliary files for mpi testing are move outside the mpi/utils folder to a specific location
  • Added back test_utility files to the cmake testing target sources.

@roigcarlo roigcarlo requested review from a team as code owners September 12, 2023 09:41
loumalouomega
loumalouomega previously approved these changes Sep 12, 2023
Copy link
Member

@loumalouomega loumalouomega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Okay

@loumalouomega loumalouomega added Kratos Core Testing Parallel-MPI Distributed memory parallelism for HPC / clusters Refactor When code is moved or rewrote keeping the same behavior labels Sep 12, 2023
@loumalouomega loumalouomega changed the title [Core][Mpi] Reorganize testing utilities [Core][MPI] Reorganize testing utilities Sep 12, 2023
@roigcarlo roigcarlo merged commit 0e02e8c into master Sep 12, 2023
@roigcarlo roigcarlo deleted the testing/split-test-source branch September 12, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Kratos Core Parallel-MPI Distributed memory parallelism for HPC / clusters Refactor When code is moved or rewrote keeping the same behavior Testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Compilation of MPI Kratos] Failure in compilation
3 participants