Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ContactStructuralMechanicsApplication] Minor optimization in mesh_tying_mortar_condition.cpp #11508

Merged

Conversation

loumalouomega
Copy link
Member

@loumalouomega loumalouomega commented Aug 25, 2023

📝 Description

This PR involves changes to the file mesh_tying_mortar_condition.cpp in the ContactStructuralMechanicsApplication. The PR modifies the nested loop structure within two functions, CalculateLocalLHS and CalculateLocalRHS, in the MeshTyingMortarCondition class.

The changes are as follows:

  • The loop structure for iterating over the number of degrees of freedom (dofs) on the master side has been rearranged. The outer loop now iterates over nodes on the master side (TNumNodesMaster), while the inner loops iterate over nodes on the current side (TNumNodes) and the dof index.
  • A similar rearrangement has been done for the loop structure iterating over the dofs on the slave side. The outer loop iterates over nodes on the slave side (TNumNodes), and the inner loops iterate over nodes on the current side (TNumNodes) and the dof index.
  • The calculations inside the innermost loop have also been adjusted based on the new loop structure.

In essence, this commit reorganizes the nested loop structure within the mentioned functions, likely for optimization or code clarity purposes.

🆕 Changelog

@loumalouomega loumalouomega added Applications Performance FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Aug 25, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner August 25, 2023 15:52
Copy link
Member

@AlejandroCornejo AlejandroCornejo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool

@loumalouomega loumalouomega merged commit af42c16 into master Aug 26, 2023
@loumalouomega loumalouomega deleted the contact/minor-optimization-mesh_tying_mortar_condition branch August 26, 2023 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Applications FastPR This Pr is simple and / or has been already tested and the revision should be fast Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants