Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Better debugging at entities_utilities in debug mode #11502

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This commit affects the kratos/utilities/entities_utilities.cpp file. Changes were made in various parts of the file:

  1. Licenses were adjusted in lines 7 and 8 to adhere to the proper format and alignment.
  2. Verification was added in the GetPrototypeEntity functions to ensure that the prototype is initialized before accessing it, generating error messages if not. This is done for both a GeometryType pointer and a GeometryType reference. (Only in debug)
  3. A specific error message was added that displays the type of geometry that lacks an initialized prototype in case the verification fails. (Only in debug)

This will improve debugging processes

🆕 Changelog

@loumalouomega loumalouomega added Enhancement Kratos Core Debug FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Aug 24, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner August 24, 2023 10:03
Copy link
Member

@sunethwarna sunethwarna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice :)

@loumalouomega loumalouomega merged commit d725ad8 into master Aug 24, 2023
@loumalouomega loumalouomega deleted the core/better-debugging-entities_utilities branch August 24, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Debug Enhancement FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants