Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Core] Refactor set_identity_function.h #11408

Merged
merged 1 commit into from
Aug 25, 2023

Conversation

loumalouomega
Copy link
Member

📝 Description

This PR refactors the SetIdentityFunction class in the kratos/containers/set_identity_function.h file. The changes include modifying the class definition and providing additional comments and documentation. The SetIdentityFunction class is a functor that serves as the identity function, allowing objects to be used as keys in sets or other containers that require comparison. The class provides two overloaded operator() functions, one for non-const objects and another for const objects, both of which return the input object as it is. The purpose of this refactoring is to improve code clarity and maintainability. The PR also adds appropriate pragma once directives and organizes the include statements.

🆕 Changelog

@loumalouomega loumalouomega added Cleanup Kratos Core FastPR This Pr is simple and / or has been already tested and the revision should be fast labels Jul 21, 2023
@loumalouomega loumalouomega requested a review from a team as a code owner July 21, 2023 10:29
@loumalouomega loumalouomega requested a review from roigcarlo August 4, 2023 08:47
@loumalouomega loumalouomega merged commit 0ef8fd1 into master Aug 25, 2023
@loumalouomega loumalouomega deleted the core/clean-up-set_identity_function branch August 25, 2023 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Cleanup FastPR This Pr is simple and / or has been already tested and the revision should be fast Kratos Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants