WA: Disable JS legacy transformation manually until it is completely removed from the atomicfu plugin. #4223
Conversation
…removed from the atomicfu plugin. Fixes KT-71203
|
|
||
| atomicfu { | ||
| transformJs = false | ||
| } |
There was a problem hiding this comment.
But kotlinx-coroutines-reactive doesn't build any JS artifacts. Of the subprojects listed, only -core, -test, and test-utils do. Is this really needed?
|
|
||
| atomicfu { | ||
| transformJs = false | ||
| } |
There was a problem hiding this comment.
Can't this be put into buildSrc/src/main/kotlin/configure-compilation-conventions.gradle.kts? The atomicfu plugin is applied there, and it would be nice to keep the related logic close together.
There was a problem hiding this comment.
I applied this config in configure-compilation-conventions in the last commit)
| @@ -22,3 +22,7 @@ kotlin { | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| atomicfu { | |||
There was a problem hiding this comment.
| atomicfu { | |
| // workaround for KT-71203. Can be removed after https://github.com/Kotlin/kotlinx-atomicfu/issues/431 | |
| atomicfu { |
?
There was a problem hiding this comment.
Added this comment 🙏
|
|
||
| configure(subprojects) { | ||
| val project = this | ||
| if (name in sourceless) return@configure | ||
| apply(plugin = "org.jetbrains.kotlinx.atomicfu") | ||
| // Workaround for KT-71203. Can be removed after https://github.com/Kotlin/kotlinx-atomicfu/issues/431 | ||
| afterEvaluate { |
There was a problem hiding this comment.
The problem is that AtomicFUPluginExtnesion type is not accessible in the root build script yet, and seems that the only way to dynamically set the property in this extension class is via reflection 🥲
(At least the config is not scattered across the build scripts of all the subprojects)
There was a problem hiding this comment.
How about something like this? 60c0707
There was a problem hiding this comment.
Cool! Thanks, that's much better and solves the problem)
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
…removed from the atomicfu plugin. (#4223) Fixes KT-71203 --------- Co-authored-by: Dmitry Khalanskiy <dmitry.khalanskiy@jetbrains.com>
Fixes KT-71203
Through an oversight
atomicfu-gradle-pluginkept tranformJs option (corresponding to the legacy JS transformation) enabled by default, and with no *.js files to transform it just copied the compileJs output directory, which led to an error described in KT-71203.I suggest to manually disable JS transformation in all subprojects, which apply atomicfu plugin (I couldn't do it more gracefully in the root build script 😔 ).
This fix can be removed as soon as JS transformation is removed completely in atomicfu library. I plan to prepare a corresponding commit and provide it with the next kotlinx-atomicfu release.