This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(base) avoid a crash when self.lastQuery is not set #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I cannot reproduce this easily, but I've had a crash in the logs caused by attempting to dereference `self.lastQuery.expire` when `self.lastQuery` was `nil`. Patched it like this to match the coding style present in this module.
locao
approved these changes
Dec 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I cannot reproduce this easily, but I've had a crash in the logs
caused by attempting to dereference
self.lastQuery.expirewhenself.lastQuerywasnil.Patched it like this to match the coding style present in this
module.