This repository has been archived by the owner on Jul 11, 2023. It is now read-only.
fix(base) reduce the amount of timers used #105
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the timers so that instead of creating one per balancer we crete a single global one. The price payed is that we must store a `glocal` variable with all the lbs inside. The DNS refresh is async so no further timers/threads are needed. Note that the single global recurring timer is now marked as "detached" so that it is not garbage-collected.
|
Superseded by #112 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the timers so that instead of creating one per
balancer we crete a single global one. The price payed is that
we must store a
glocalvariable with all the lbs inside.The DNS refresh is async so no further timers/threads are needed.
Note that the single global recurring timer is now marked as
"detached" so that it is not garbage-collected.