feat: support arbitrary Kuma Helm values #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9338eba to
8aded75
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #958 +/- ##
===========================================
- Coverage 60.17% 48.66% -11.51%
===========================================
Files 50 50
Lines 4045 4054 +9
===========================================
- Hits 2434 1973 -461
- Misses 1304 1810 +506
+ Partials 307 271 -36
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
shaneutt
approved these changes
Feb 5, 2024
programmer04
approved these changes
Feb 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for arbitrary chart settings to the Kuma plugin, inspired by the existing Kong plugin functionality.
I added this to test some additional Kuma settings in CI to try and find some fix for the KIC session stickiness issues we've seen with Kong 3.6. Didn't find any fix, but this is generic enough that we may as well add it anyway.