feat: use kuma version when installing it #949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #949 +/- ##
===========================================
- Coverage 60.19% 42.41% -17.79%
===========================================
Files 50 50
Lines 4032 4039 +7
===========================================
- Hits 2427 1713 -714
- Misses 1300 2089 +789
+ Partials 305 237 -68
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bfaba2d to
891d46e
Compare
891d46e to
711ae39
Compare
shaneutt
reviewed
Feb 2, 2024
pmalek
reviewed
Feb 5, 2024
programmer04
previously approved these changes
Feb 5, 2024
|
When your PR will be merged and this #946 too I think we can release a new version |
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
programmer04
previously approved these changes
Feb 5, 2024
pmalek
previously approved these changes
Feb 5, 2024
programmer04
approved these changes
Feb 5, 2024
randmonkey
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
randmonkey
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
rainest
pushed a commit
that referenced
this pull request
Mar 27, 2024
Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
czeslavo
added a commit
that referenced
this pull request
Mar 29, 2024
* feat: install default allow-all traffic permission when kuma >= 2.6.0 (#957) * feat: use kuma version when installing it (#949) Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com> * chore: test on PRs to release branches * run lint workflow for all branches * fix linter issues --------- Co-authored-by: Grzegorz Burzyński <czeslavo@gmail.com> Co-authored-by: Jakub Warczarek <jakub.warczarek@konghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Kuma addon builder we allow setting a version, but we don't use it when calling
helm install.