Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support arbitrary values in helm install #776

Merged
merged 1 commit into from
Aug 15, 2023

Conversation

randmonkey
Copy link
Contributor

support setting arbitrary values in installing kong by helm to support setting images.effectiveSemver to fix parsing semver in s integration tests against kong nightly image.
REVIEW: move the setting of other values to addon.addtionalValues?

@randmonkey randmonkey requested review from shaneutt and a team as code owners August 15, 2023 08:57
@randmonkey randmonkey temporarily deployed to gcloud August 15, 2023 08:57 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 15, 2023 08:57 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 15, 2023 08:57 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 15, 2023

Codecov Report

Patch coverage: 53.84% and project coverage change: -0.07% ⚠️

Comparison is base (045419a) 60.20% compared to head (caaf805) 60.14%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #776      +/-   ##
==========================================
- Coverage   60.20%   60.14%   -0.07%     
==========================================
  Files          48       48              
  Lines        3905     3914       +9     
==========================================
+ Hits         2351     2354       +3     
- Misses       1262     1267       +5     
- Partials      292      293       +1     
Flag Coverage Δ
integration-test 60.14% <53.84%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/clusters/addons/kong/addon.go 59.50% <0.00%> (-0.41%) ⬇️
pkg/clusters/addons/kong/builder.go 84.34% <70.00%> (-1.90%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rainest rainest left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This could sorta screw with the additional env setting, but I don't think there's a need for guardrails. If you knowingly use both options to set env, woe be upon you.

@rainest rainest merged commit d2b2737 into main Aug 15, 2023
@rainest rainest deleted the feat/kong_addon_support_arbitrary_values branch August 15, 2023 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants