-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kong): allow customizing chart version and proxy readiness probe #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czeslavo
force-pushed
the
customize-kong-addon
branch
from
August 10, 2023 10:41
23454ad
to
c8ccafb
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #774 +/- ##
===========================================
- Coverage 59.70% 20.79% -38.91%
===========================================
Files 48 48
Lines 3886 3900 +14
===========================================
- Hits 2320 811 -1509
- Misses 1271 2965 +1694
+ Partials 295 124 -171
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
czeslavo
force-pushed
the
customize-kong-addon
branch
from
August 10, 2023 10:57
c8ccafb
to
5d718b1
Compare
czeslavo
force-pushed
the
customize-kong-addon
branch
from
August 10, 2023 10:58
5d718b1
to
f059f99
Compare
czeslavo
force-pushed
the
customize-kong-addon
branch
from
August 10, 2023 10:59
f059f99
to
ddfc98f
Compare
czeslavo
force-pushed
the
customize-kong-addon
branch
from
August 10, 2023 11:11
ddfc98f
to
c84845d
Compare
pmalek
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
WithHelmChartVersion
andWithProxyReadinessProbePath
Kong addon builder methods. Modifies theWithControllerDisabled
method to also alter theproxyReadinessProbePath
to/status
so that the installation succeeds if the controller is disabled (otherwise/status/ready
default would be used which expects Gateway to have a non-empty config loaded/configured).