Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kong): allow customizing chart version and proxy readiness probe #774

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

czeslavo
Copy link
Contributor

@czeslavo czeslavo commented Aug 10, 2023

Adds WithHelmChartVersion and WithProxyReadinessProbePath Kong addon builder methods. Modifies the WithControllerDisabled method to also alter the proxyReadinessProbePath to /status so that the installation succeeds if the controller is disabled (otherwise /status/ready default would be used which expects Gateway to have a non-empty config loaded/configured).

@codecov-commenter
Copy link

codecov-commenter commented Aug 10, 2023

Codecov Report

Patch coverage: 29.41% and project coverage change: -38.91% ⚠️

Comparison is base (d6d384b) 59.70% compared to head (ddfc98f) 20.79%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #774       +/-   ##
===========================================
- Coverage   59.70%   20.79%   -38.91%     
===========================================
  Files          48       48               
  Lines        3886     3900       +14     
===========================================
- Hits         2320      811     -1509     
- Misses       1271     2965     +1694     
+ Partials      295      124      -171     
Flag Coverage Δ
integration-test 20.79% <29.41%> (-38.91%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/clusters/addons/kong/addon.go 17.76% <0.00%> (-40.67%) ⬇️
pkg/clusters/addons/kong/builder.go 53.84% <45.45%> (-33.66%) ⬇️

... and 34 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 10:41 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 10:41 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 10:41 — with GitHub Actions Inactive
@czeslavo czeslavo force-pushed the customize-kong-addon branch from c8ccafb to 5d718b1 Compare August 10, 2023 10:57
@czeslavo czeslavo force-pushed the customize-kong-addon branch from 5d718b1 to f059f99 Compare August 10, 2023 10:58
@czeslavo czeslavo force-pushed the customize-kong-addon branch from f059f99 to ddfc98f Compare August 10, 2023 10:59
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:00 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:00 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:00 — with GitHub Actions Inactive
@czeslavo czeslavo force-pushed the customize-kong-addon branch from ddfc98f to c84845d Compare August 10, 2023 11:11
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:12 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:12 — with GitHub Actions Inactive
@czeslavo czeslavo temporarily deployed to gcloud August 10, 2023 11:12 — with GitHub Actions Inactive
@czeslavo czeslavo self-assigned this Aug 10, 2023
@czeslavo czeslavo added the area/feature New feature or request label Aug 10, 2023
@czeslavo czeslavo marked this pull request as ready for review August 10, 2023 11:18
@czeslavo czeslavo requested review from shaneutt and a team as code owners August 10, 2023 11:18
@czeslavo czeslavo enabled auto-merge (squash) August 10, 2023 11:24
@czeslavo czeslavo requested review from pmalek and randmonkey August 10, 2023 11:29
@czeslavo czeslavo merged commit 1b08206 into main Aug 10, 2023
@czeslavo czeslavo deleted the customize-kong-addon branch August 10, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants