Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support setting namespace in kong addon #766

Merged
merged 4 commits into from
Aug 1, 2023

Conversation

randmonkey
Copy link
Contributor

support to specify namespace of Kong addon to deploy Kong in certain namespace. Fixes #765

@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 06:39 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 06:39 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 06:39 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 07:32 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 07:32 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 07:32 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023

Codecov Report

Patch coverage has no change and project coverage change: -46.74% ⚠️

Comparison is base (c097dbd) 60.09% compared to head (6ce10f0) 13.35%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main     #766       +/-   ##
===========================================
- Coverage   60.09%   13.35%   -46.74%     
===========================================
  Files          48       48               
  Lines        3882     3885        +3     
===========================================
- Hits         2333      519     -1814     
- Misses       1257     3293     +2036     
+ Partials      292       73      -219     
Flag Coverage Δ
integration-test 13.35% <0.00%> (-46.74%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/clusters/addons/kong/builder.go 53.12% <0.00%> (-37.20%) ⬇️

... and 42 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pmalek pmalek added the area/feature New feature or request label Aug 1, 2023
test/integration/kongaddon_test.go Outdated Show resolved Hide resolved
test/integration/kongaddon_test.go Outdated Show resolved Hide resolved
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:40 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:40 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:40 — with GitHub Actions Inactive
@randmonkey randmonkey force-pushed the feat/support_namespace_for_kong_addon branch from 6ce10f0 to cab708a Compare August 1, 2023 09:47
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:47 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:47 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 09:47 — with GitHub Actions Inactive
@randmonkey randmonkey force-pushed the feat/support_namespace_for_kong_addon branch from cab708a to a1a0a7d Compare August 1, 2023 09:59
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 10:00 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 10:00 — with GitHub Actions Inactive
@randmonkey randmonkey temporarily deployed to gcloud August 1, 2023 10:00 — with GitHub Actions Inactive
@randmonkey randmonkey requested review from pmalek and czeslavo August 1, 2023 10:11
@randmonkey randmonkey merged commit e7b7098 into main Aug 1, 2023
@randmonkey randmonkey deleted the feat/support_namespace_for_kong_addon branch August 1, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support changing namespace of kong addon builder
4 participants