Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix command error handling when error is nil #527

Merged
merged 1 commit into from
Feb 2, 2023
Merged

fix: fix command error handling when error is nil #527

merged 1 commit into from
Feb 2, 2023

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Feb 2, 2023

No description provided.

@pmalek pmalek self-assigned this Feb 2, 2023
@pmalek pmalek marked this pull request as ready for review February 2, 2023 13:32
@pmalek pmalek requested a review from a team as a code owner February 2, 2023 13:32
@pmalek pmalek enabled auto-merge (squash) February 2, 2023 13:32
shaneutt
shaneutt approved these changes Feb 2, 2023
View reviewed changes
Copy link
Contributor

@shaneutt shaneutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no description, but this seems to be self-explanatory. LGTM.

@shaneutt shaneutt disabled auto-merge February 2, 2023 15:17
@shaneutt shaneutt merged commit f41d719 into main Feb 2, 2023
@shaneutt shaneutt deleted the fix-command-error-handling branch February 2, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shaneutt shaneutt shaneutt approved these changes

Assignees

@pmalek pmalek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pmalek @shaneutt