fix: remove cluster init token check

[shaneutt]

Back when we first made KTF we added a check to wait for the service account that would be used for testing until it's Secret was generated. Modern versions of Kubernetes since v1.24.0 have a different implementation for ServiceAccounts which doesn't make this secret available like it used to be. As such this patch removes the check as it is irrelevant going forward and is breaking recent deployments.

[codecov-commenter]

Codecov Report

Merging #273 (8fdff88) into main (31a6656) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #273   +/-   ##
=======================================
  Coverage   11.75%   11.75%           
=======================================
  Files           5        5           
  Lines         604      604           
=======================================
  Hits           71       71           
  Misses        528      528           
  Partials        5        5           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df000e6...8fdff88. Read the comment docs.

[mflendrich]

So the wait is not necessary anymore?

[shaneutt]

So the wait is not necessary anymore?

The wait was probably never really necessary in the first place, but it's definitely not necessary now. In fact, it simply won't work because the Secret is no longer made.

[mflendrich]

Did some research:

This KEP says

The NodeAuthorizer will allow the kubelet to use its credentials to request a service account token on behalf of pods running on that node.

Which means that getting SA credentials for a pod is now a synchronous operation performed by kubelet.

[shaneutt]

https://github.com/kubernetes/enhancements/tree/master/keps/sig-auth/2799-reduction-of-secret-based-service-account-token is the KEP for posterity, if anyone is seeing and wanting to better understand this PR in the future.