Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid tag generation in CI #964

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Fix invalid tag generation in CI #964

merged 1 commit into from
Nov 30, 2020

Conversation

rainest
Copy link
Contributor

@rainest rainest commented Nov 25, 2020

What this PR does / why we need it:
CI is sad; this makes it not sad.

Special notes for your reviewer:

push-public has

if: github.ref == 'refs/heads/main' || github.ref == 'refs/heads/next'

so this doesn't actually execute until the commit lands in main. This should suffice to confirm it gets what we want:

$ export GITHUB_REF="refs/heads/main"   
$ REF=`sed -re "s/^refs\/[a-z]+\///" <<< $GITHUB_REF`; echo $REF 
main

IDK much about bash's built-in pattern matching language, but brief research suggests it doesn't support the + operator or the PCRE-style classes we're using. sed definitely does, so may as well use that.

@mflendrich mflendrich merged commit 62f024e into main Nov 30, 2020
@mflendrich mflendrich deleted the ci/bash-error branch November 30, 2020 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants